Open King-Jaden opened 1 year ago
You need to add a description
You need to add a description
Thanks you. I believe I just completed my description.
Description looks good. I would also add that a period is often used as a digit separator and should be include in your test cases - xxx.xxx.xxxx
My recommendation would be to separate possible phone number detection from validation. You could open a separate issue later if you decide you want to try to validate the area code on possible phone numbers.
Updated one last time. Thank you.
Will this handle foreign phone numbers as well? They have a different starting digit based on their country.
Will this handle foreign phone numbers as well? They have a different starting digit based on their country.
No. Just for the sake of simplicity, I will only be handling and searching for American Phone Numbers, and assume unlabeled phone numbers (Those without the initial value signifying an international country code) are American.
I like how you covered all the various formats that phone numbers can abide by.
Will this handle foreign phone numbers as well? They have a different starting digit based on their country.
@King-Jaden I think you will find that the default Presidio recognizer discussed in the sprint instructions will work pretty well for detecting phone numbers
My project will focus on detecting 10-digit American phone numbers. Phone numbers are often tied to the lives of their holders, and can even be used for 2-step verification in a variety of circumstances. Detecting phone numbers should allow me to better protect the individuals who don't know the importance of their anonymity.
I will most likely detect these phone numbers by scanning for specific and common formats of phone numbers such as:
1-xxx-xxx-xxxx, xxx-xxx-xxxx, xxxxxxxxx 1-(xxx)-xxx-xxxx (xxx)-xxx-xxxx xxx.xxx.xxxx
Reviewing whether or not the first three digits are a currently available American Area code could be a separate but linked issue to review later.