Closed Jsostmann closed 4 years ago
Which function are you implementing the starting path for? See this post - Team Pecan Cookies is working from the files mentioned in that post.
ohhhh okay I see now. Thanks!
# dataframe_list
# List of pandas dataframe objects
#
OK, this is a good start
@claesmk
Hey Mr. Mike, I had a quick question about ignoring files. I forked the Repo and when I try to push my changes, the trip_logs.csv
file is too large. Would it be okay if I added *.csv
to the .gitignore
file?
You bring up an excellent point @Jsostmann. When you first clone the repo there are a couple of .csv files included in the repo that are used for testing purposes.
It's not until you run the demo.py file that the remaining csv files get created. I did not check-in those on purpose because I expected everyone to run the demo and download them, I don't want those to get check-in to the repo.
If you ignore *.csv you will block upload of some csv files we might need to keep in the repo. What you could do is add just the files we expect to have downloaded (airlines.csv, airports.csv, flights.csv, and trip_logs.csv)
What you should do is open a new issue for this and in that issue just commit the changes to .gitignore
Oh okay! so your saying that inside .gitignore
just add
...
...
airlines.csv
airports.csv
flights.csv
trip_logs.csv
instead of *.csv
because these are just the test files we assume everyone has downloaded locally already?
I think you will need to add the full relative path - ie
data/trip_logs/trip_logs.csv
Okay, Thanks for the clarification!