search

NCATS-Gamma / robokop

Master UI for ROBOKOP
MIT License
16 stars 3 forks source link

NLP parser incorrectly returns predicates for edges under 'predicate' instead of 'type' #178

Open HamsterHuey opened 5 years ago

HamsterHuey commented 5 years ago

@patrickkwang mentioned that this should be type. OpenAPI docs do not have either of these documented for the specification for edges. Currently, the UI has been implemented assuming that the predicate term will be returned under type.

On a related note, @cbizon , @kennethmorton - Is there any conceivable reason why one might have more than one predicate on an edge? This would impact whether the type of the type param can simply be a string or whether it should be a list of strings. Currently it's been implemented to support a list of strings.

sudeepmandal commented 5 years ago

Oops, posted issue from my personal account :-)