NCATS-Gamma / robokop

Master UI for ROBOKOP
MIT License
16 stars 3 forks source link

Predicates #293

Open karafecho opened 5 years ago

karafecho commented 5 years ago

In the question builder, the meaning of predicates, as well as the choice of predicates, is unclear to users. Perhaps add a ? box to provide a brief explanation.

cbizon commented 5 years ago

Most of these predicates map to an RO term, so we could probably pull a description for most of them from somewhere, and that should help with the meaning part.

I'm not sure what you mean by "the choice of predicates" though, can you explain a bit more?

karafecho commented 5 years ago

I think your suggestion would resolve my issue.

kennethmorton commented 5 years ago

@cbizon if you know of a way to pull a description for a given term, we can integrate it into the UI somehow.

cbizon commented 5 years ago

If RO is loaded into onto.renci.org or uberongraph, we should be able to pull it from there... @balhoff I think RO is in uberongraph, is that right? Does it contain the definition text?

balhoff commented 5 years ago

Yes, all of RO is loaded:

https://github.com/NCATS-Tangerine/ubergraph/blob/45243f8b59c5795493fb569befea2c3fc5d46b90/ontologies.ofn#L17

cbizon commented 5 years ago

@cbizon to compile predicate descriptions - probably put them in biolink-model_overlay.yaml @kennethmorton to take it from there to the UI (at least I think that's what I'm reading in my notes. If somebody has a clearer recollect, please comment)

cbizon commented 5 years ago

There is now a little script in https://github.com/NCATS-Gamma/robokop-interfaces/blob/master/scripts/export_descriptions.py that pulls the description field from our biolink model files for all the predicates and puts them into this file: https://github.com/NCATS-Gamma/robokop-interfaces/blob/master/scripts/predicates.tsv

Most of these are coming from some underlying ontology like RO, so they have a very formal flavor. It's a fine starting place, but I could imagine wanting to make them a bit more user friendly?