NCATS-Gamma / robokop

Master UI for ROBOKOP
MIT License
16 stars 3 forks source link

Unconnected graph in results #533

Open cbizon opened 4 years ago

cbizon commented 4 years ago

This is on covidkop.renci.org

https://covidkop.renci.org/a/463114b4-e965-4a06-b330-c460bd0c8291_f47f602c-5011-4896-8812-fc08a22cfe9e/

The query goes (covid)<-[in taxon]-(gene)-(gene)

The answers are all strangely disconnected:

image

Also, I would expect support edges

kennethmorton commented 4 years ago

Digging in, it looks like there is a disconnect with the edges reported in the answers and those in the knowledge graph. For answer number 1, the answer lists 3 edges:

"edge_bindings": {
        "e0": [
            "78f579a954dfa8b39669c202dc1352f2"
        ],
        "e1": [
            "209b803410c5a06a4db829b957027bd4"
        ],
        "s831": [
            "862795ec-a7c6-447e-91ab-c2c39105a690"
        ]
    }

However, only e1 is present in the knowledge graph. e0 78f579a954dfa8b39669c202dc1352f2 is the edge displayed above. s831 is a support edge which is also missing.

This doesn't seem to be a UI bug. The UI is displaying the provided information correctly as far as I can tell.

@patrickkwang

cbizon commented 4 years ago

I ran this query through covidkop / messenger, and it looks like the resulting graph is correct, i.e. the kg_ids in the first result all exist in the knowledge_graph.

I can't remember whether the live instance uses messenger or not, but I thought it does, so then I guess maybe there's something funky going on between messenger and the ui