search

NCATS-Tangerine / beacon-aggregator

A web service that operates over the Beacon network to provide a single software interface over the all the Beacons
Other
2 stars 0 forks source link

[WIP] Tentitive bug fix #70

Closed lhannest closed 6 years ago

lhannest commented 6 years ago

This fixes a concurrency bug wherein the beacons list is being modified (on another thread, it seems) while being iterated through. This bug is why nDex often times disappears from the list of beacon statuses, when it times out. With this PR instead the nDex beacon reports an error status code, instead of disappearing from the status list.

I consider this a tentitive fix because while it prevents the problematic behavior, the underlying design flaw still exists.

RichardBruskiewich commented 6 years ago

Hmm... we'll have to take a closer look at this design issue.