NCATS-Tangerine / translator-api-registry

This repo hosts the API metadata for the Translator project
13 stars 31 forks source link

Update smartapi.yaml #116

Closed GitHubbit closed 1 year ago

GitHubbit commented 1 year ago

Updates to smartapi.yaml for Multiomics Clinical Trials KP for compatibility with TRAPI 1.4 edge sources specification @colleenXu

colleenXu commented 1 year ago

@GitHubbit I did a quick test and it seemed to work properly with BTE, which is great. Please leave it in this fork for now (we'll only merge this PR when we move all instances to TRAPI 1.4).

We'll hopefully deploy a SmartAPI override file soon https://github.com/biothings/biothings_explorer/blob/trapi1-4-overrides/src/config/smartapi_overrides.json, which will allow the dev instance of BTE to use your fork's file and do TRAPI 1.4 source formatting properly for your KP.

One note:

colleenXu commented 1 year ago

SmartAPI override file has been deployed. So BTE's dev instance should be showing the TRAPI 1.4 sources data correctly using the data in the BioThings API.

Another note:

GitHubbit commented 1 year ago

Believe this is addressed now: [https://github.com/biothings/biothings_explorer/issues/617#issuecomment-1562026459](Multiomics ClinicalTrials KP: NEEDED SmartAPI yaml edits) TRAPI 1.3 only

colleenXu commented 1 year ago

@GitHubbit

I've looked at these edits, but I haven't tested them myself. I agree that they should fix the x-bte annotation issues for the registered yaml, which BTE's prod instance uses and is for TRAPI 1.3 support.

The next steps are:

And after that is testing!

colleenXu commented 1 year ago

The registered yaml should now be working and "TRAPI 1.4", after this PR merge and https://github.com/NCATS-Tangerine/translator-api-registry/commit/59c6a562b6f8f39105819f5c6424b9b6c8a317c9.

The override yaml in the fork is working but probably isn't "TRAPI 1.4" because the source.edge_sources info is missing.