search

NCATS-Tangerine / translator-knowledge-beacon

NCATS Translator Knowledge Beacon Application Programming Interface plus Sample code
MIT License
7 stars 2 forks source link

Distinguish between Biolink and local type id mappings in /categories and /predicates #48

Open RichardBruskiewich opened 6 years ago

RichardBruskiewich commented 6 years ago

With the introduction of the shared biolink semantic model, it is still useful to expose the "local_id" which is being mapped onto the Biolink Model. We should modify the JSON output accordingly, with a "local_id" field (and possibly, a xrefs field?)

micheldumontier commented 6 years ago

we should use prefixed ids

RichardBruskiewich commented 6 years ago

Hi Michel, I just noticed your commentary. All id's are CURIEs The issue here relates to the need to send back both the (new) biolink model term concept 'category' and the original concept type (e.g. SIO, WD, UMLS) in the beacon knowledge source itself. Those latter id's should be curated into a 'mapping' field of the Biolink model YAML, but the question is whether to still echo them back to the user (in various beacon API JSON output results).

Actually, this issue here is now a bit duplicate to commentary on the knowledge metamap issue (https://github.com/NCATS-Tangerine/translator-knowledge-beacon/issues/40). See that for more details.

micheldumontier commented 6 years ago

sure.