search

NCATSTranslator / Feedback

A repo for tracking gaps in Translator data and finding ways to fill them.
7 stars 0 forks source link

Infores - URL Links to smart-api and others (HPO annotations) are sometimes "broken" #151

Closed sstemann closed 1 year ago

sstemann commented 1 year ago

While this issue is surfaced in the UI, its the same issue if you just use the URL from the infores catalog.

Steps:

  1. Run MVP1 for Stromme Syndrome in the CI UI: https://ui.ci.transltr.io/results?l=Stromme%20Syndrome&t=0&q=acbbc8ba-ff1d-4d40-990e-17deb36ba569

  2. Search for result "Corticotropin".

  3. On the Path from Corticotropin "treats" West Syndome, click the Treats Edge.

  4. In the Evidence pop-up click the Sources tab image

  5. Click the link provided for SRI Reference Knowledge Graph API http://smart-api.info/registry?q=1a41e3cd15f2b3bfa21c99900bfa1720 image

  6. This URL is the same as here: https://github.com/biolink/biolink-model/blob/master/infores_catalog_nodes.tsv image

  7. It looks like it works for some (Biothings, TMKP) but not others (Automats, SRI) .

  8. Also seems inconsistent what page in SmartAPI it's going to which is very different experiences

  9. Can we ask for the teams to QC their infores before the data evidence deadline (3/24)? @cbizon @sierra-moxon @mbrush @cartmanbeck

sstemann commented 1 year ago

Also the HPO Link does not work in the UI. it matches the infores page, so i assume this is an infores issue.

image

image

image

sierra-moxon commented 1 year ago

from TAQA: URLs need to be updated and working! :)

Andy: The ideal here is that the user understands the process that we used to get the edge, or the source itself. e.g.: do they trust it a little, or a lot? When thinking about where to link people to, that kind of idea is what we should push for. Add value to the edge. smart API links should go away - not helpful for users/hard to understand. GitHub links could go either way - sometimes they have nice READMEs, etc. sometimes the user just wants to know the methodology.

Tyler: I've started to review; looking for more links to add. Perhaps add the specific CURIE that the user need to "plug in" to the specific page that gave the edge. We don't need to pull back the "supporting" sources under the specific link we point them to.

Kara: Translator wiki pages could be leveraged! https://github.com/NCATSTranslator/Translator-All/wiki

sierra-moxon commented 1 year ago

fixed hpo url https://github.com/biolink/biolink-model/pull/1266