NCATSTranslator / Feedback

A repo for tracking gaps in Translator data and finding ways to fill them.
7 stars 0 forks source link

Search for a disease and filter for connected diseases #357

Open TranslatorIssueCreator opened 1 year ago

TranslatorIssueCreator commented 1 year ago

Type: Bug Report

URL: https://ui.transltr.io/results?l=Autism%20Spectrum%20Disorder&t=0&q=eea2d5cc-af99-469f-9fab-ba74108a8fe8

ARS PK: eea2d5cc-af99-469f-9fab-ba74108a8fe8

Steps to reproduce:

What drug may treat Autism Spectrum Disorder?

Screenshots:

sandrine-m commented 1 year ago

I search for Autism Spectrum Disorder with MVP1 template. I get "Aripiprazole -- treats -- Asperger Syndrome" in result 2 above other results matching for Autism Spectrum Disorder

image

The ranking shouuld take into consideration matched term OR propose to the user to unselect some of "connected diseases".

Genomewide commented 1 year ago

This is because ARAs are not providing the 'subclass of' edge to connect back to the target disease. The graph will also have two ending-diseases. It is not great, but the UI is showing what is returned to us.

image

This should be closed unless someone disagrees or I missed the point?

sandrine-m commented 1 year ago

Thank you @Genomewide ! Not ideal, I agree. I'll remove the UI label and park this in O&O. This issue is clearly not a priority but I think should still be considered. For me it is the same type of issue that issues that have the "occurs together with" (where comorbidities are present...etc.) IMO, results with predicates "occurs together with" should be a different category of results (connex results) at the end/on the side with something in the UI saying "you might be interested in these results...". Adding "connex results" labels

sandrine-m commented 1 year ago

after discussion with @Genomewide re-triaging all grouping issues into 2 labels: UI-feature request, connex results to easy up new features discussions post realease.

gprice1129 commented 11 months ago

@sandrine-m its not clear what the UI feature request is for this ticket. Can you please clarify?

sandrine-m commented 11 months ago

Thanks @gprice1129 for reviving this issue. I would like to filter results that uses paths that contains a disease. One easy way (short term) to solve (maybe not the best option for user as it can be fastidious) would be to have an opposite function of the filter: an exclusion criteria and let user specify each disease as an exclusion criteria. The best way that I see (longer term) to solve this issue (but that will require updates on tooling), would be to offer users to filter or exclude certain reasoning path types (topology): the user here would like to remove results that contain paths that are of the form : ...->....->.... -"occurs together with"-> my disease

sandrine-muller-research commented 11 months ago

Retested today on PROD: I could not find the same problematic paths under Aripiprazole but we do have problematic paths in my opinion (not very clever reasoning, often leading to bad results IMO):

image

They all contain xxx--treats -- xxx --Phenotype of-- with no Genes as intermediary nodes

sstemann commented 1 month ago

@gprice1129 are there designs for these for a upcoming release or next phase or out of scope?

dnsmith124 commented 1 month ago

@sstemann the UI team is not currently planning to implement this before the end of the funding period