NCATSTranslator / Feedback

A repo for tracking gaps in Translator data and finding ways to fill them.
7 stars 0 forks source link

Fully semantically valid biolink 3.5.0 + TRAPI 1.4.0 from all actors #379

Open sierra-moxon opened 1 year ago

sierra-moxon commented 1 year ago

Check each of these off when the validation is passing (for example, this test shows an arax interface with red x's that show validation issues ) for your resource.

codewarrior2000 commented 1 year ago

What is the implication of checking off for "Fully semantically valid biolink 3.5.0 + TRAPI 1.4.0 from all actors"? Do we just check off if that given example has no red X for our actor? Or is there a set of standard tests on ARAX that we should be running before we can check off for our actor? Should we be continuously testing and then uncheck our actor if, at a later time, validation doesn't pass?

edeutsch commented 1 year ago

I have updated the ARAX GUI to use version 3.6.5 of the TRAPI validator and Biolink 3.5.0. Therefore all displayed validation is against our target.

There is now also a distinction between critical errors (red X) and ordinary errors (orange !) image

Perhaps this is useful for reaching our goals. https://arax.ci.transltr.io/?r=704b6fac-c47c-420e-b6e5-8be46ea9bf35

colleenXu commented 11 months ago

I think the Exploring / Service team tools (BTE / Service Provider TRAPI) have almost reached this goal.

The current (as-of late last Friday) orange errors + warnings are being addressed with changes to other tools:

So...we may not show up as "passing validation" until these changes are fully deployed. I'm not sure of everything that's involved in this deployment (biolink-model release? -> reasoner-validator / biolink-model toolkit updates? -> ARAX UI update? and maybe BTE/Service Provider tools need to update which biolink-model version they advertise using?)

sierra-moxon commented 11 months ago

We will need a BMT release as well. I’d like to see if there are more attributes that need to be added to the model (as people go through the validation warnings) before doing that. For example, will a property for “semmed novelty score” need to be added?

andrewsu commented 11 months ago

will a property for “semmed novelty score” need to be added?

I do not think this is necessary -- I think the plan is to do filtering at ETL/query time, rather than passing this info back to the user.

colleenXu commented 11 months ago

Going to check us off as "done", since we show up with a "green check" in ARAX CI - which is using reasoner-validator 3.8.0 configured to validate against Biolink model 3.5.3 (but may have TRAPI validation warnings sometimes), based on two quick checks.

Regarding Multiomics + Text-Mining KPs that go through Service Provider @gglusman @edgargaticaCU, careful testing of the TRAPI responses for your KP should allow to see if your edge-attributes / sources info (which may be different for different x-bte operations / data) passes TRAPI validation. If you feel confident that all your KPs pass, then you can check it off.

codewarrior2000 commented 11 months ago

All righty! On August 11, 2023 at 1145 EDT, MolePro is also now showing green status in the ARAX GUI (the latest validator version 3.8.0 configured to validate against Biolink model 3.5.3 )

image
sstemann commented 3 months ago

@sierra-moxon what say you on this? are we still working on it?

codewarrior2000 commented 2 months ago

@sierra-moxon and @sstemann For what it's worth:

  1. This Issue's test criterion (https://arax.test.transltr.io/?r=e4420d32-65c1-4b43-9cb9-ff55564978e9) no longer provides results to validate for biolink 3.5.0 + TRAPI 1.4.0.
  2. Translator is moving to TRAPI 1.5.0.

Therefore, it seems that this Issue serves no more purpose.