search

NCATSTranslator / Feedback

A repo for tracking gaps in Translator data and finding ways to fill them.
7 stars 0 forks source link

Search History - Saved by Browser and not Tied to Account #508

Open sstemann opened 1 year ago

sstemann commented 1 year ago

Steps to recreate:

  1. Test > Login with Google+ > Run some queries, save some results, make some notes image

  2. Logout

  3. Test > Login with NIH MFA > View Workspace - it's empty, View Search History, see all the searches from step 1 image

  4. Ultimately I think this will cause confusion if you think you made notes, don't see the notes but see the search history

gglusman commented 1 year ago

The first time I saw the 'search history' feature it surprised me that it included searches I'd done way before it was released, and before I had 'logged in'. So it had to come from browser history... I agree that tying it to the browser is confusing, e.g., if one uses multiple browsers on multiple computers.

dnsmith124 commented 1 year ago

This is a quirk caused by the pre and post user account eras finally meeting now that we have user accounts available.

Moving forward there are several ways we could potentially resolve this discrepancy. Some ideas:

  1. Remove the browser-based search history, since it only logs manually submitted queries anyway (and since you can't manually submit a query while not being logged in, this feature wouldn't be missed)
  2. Maintain 2 separate sources for search history, one account-based and one browser-based, and show the history according to whether the user is logged in or not
  3. Make example query submissions add to the search history, then when a user logs in their browser-based search history could be uploaded to their account so that it displays no matter where they're logged in. This one is the most robust but also the most prone to issues or unintended saving of searches, such as in the case of a user logging in on a shared computer.

I'm partial to the first option, and there may be others that would work better than any of these. We'll discuss as a team and figure out the best path forward for this feature

gglusman commented 1 year ago

An alternative (if not too much work to implement): offer a time-limited button to 'import from browser history to account history'. Make that button available for a couple of weeks, then drop it and forget about the old browser history thing. :)

dnsmith124 commented 1 year ago

@gglusman that would be a great way to sunset the browser-based history in favor of an account-based one! I will keep this in mind

sstemann commented 2 months ago

@dnsmith124 are there going to be any changes on this or should we defer?

dnsmith124 commented 2 months ago

My vote would be to defer, this does not seem like a high-priority change.