Is ARA robokop still running?

NCATSTranslator / Feedback

A repo for tracking gaps in Translator data and finding ways to fill them.

7 stars 0 forks source link

Is ARA robokop still running? #524

Closed edeutsch closed 6 months ago

edeutsch commented 1 year ago

It seems like whenever I look at recent ARS results, robokop always returns a 404 error. Why is that? Is that okay?

https://arax.ci.transltr.io/?latest=10&from=ars.test.transltr.io

https://arax.ci.transltr.io/?latest=10&from=ars.ci.transltr.io

edeutsch commented 1 year ago

ah, found this: https://github.com/NCATSTranslator/Relay/issues/473

sandrine-m commented 1 year ago

Should we close this issue?

edeutsch commented 1 year ago

Does not seem fixed to me

uhbrar commented 1 year ago

I don't think it's fixed yet, no. I believe the ARS is still contacting Robokop. However, Robokop has been delisted from smartapi.

edeutsch commented 1 year ago

okay, thanks. There seems to be a pretty substantial disconnect between ARS and SmartAPI. What do we want ARS to be doing? I think this may be a topic for the Architecture Cttee? @cbizon ? See also https://github.com/NCATSTranslator/Relay/issues/501#issuecomment-1712171379

sierra-moxon commented 11 months ago

@newgene - just wanted to get your feedback on the next steps here to hopefully resolve the disconnect between ARS and SmartAPI that @edeutsch notes? Do we need this to go to a particular team or is it a discussion-level ticket?

edeutsch commented 11 months ago

I suspect this is an issue for the ARS team @MarkDWilliams @ShervinAbd92 . Or perhaps better a topic for Architecture call on how we all agree that the ARS should be operating. Based on observing what happens, I suspect that ARS has a hard-coded set of endpoints that it hits, and it is not based on SmartAPI. and that hard-coded list hasn't been updated in a long time. But I am uncertain.

ah, looking again this morning, it seems that Robokop has now been removed: https://arax.ci.transltr.io/?latest=10&from=ars.ci.transltr.io

The issue that ARS still hits a subset of KPs remains: https://arax.ci.transltr.io/?r=46c9678f-52fe-4c72-ad97-265852ed262e Do we want ARS to be doing that? Should ARS:

Continue to hit a subset of KPs
Hit only ARAs and not KPs
Hit all KPs based on SmartAPI instead of a hard-coded subset?

This seems like a policy issue that should be discussed at Architecture.

cbizon commented 11 months ago

@MarkDWilliams can you comment here please on these issues?

MarkDWilliams commented 11 months ago

Happy to reassess what the ARS hits. As to the URLs, there shouldn't be any hardcoded URLs that we hit that aren't based on SmartAPI. However, there is a hard coded fallback that can come into play if for some reason, there was a failure to pull the current information from SmartAPI for some reason, but barring that, all the URLs should be pulled from SmartAPI at boot time.

cbizon commented 11 months ago

So the lag between ROBOKOP being de-listed on SmartAPI and ARS is just because ARS didn't refresh?

MarkDWilliams commented 11 months ago

Ah no, that would be a case where likely the ARS wasn't able to find the registration and falling back to the URL we have in the backup config file. This behavior could be changed to have the ARS just skip anything it can't get a SmartAPI pull for if folks think that would be preferable.

sierra-moxon commented 8 months ago

fixable this month on the ARS side. from tAQA: just kill it.

ShervinAbd92 commented 6 months ago

robokop agent has been removed from ARS side.