NCATSTranslator / Feedback

A repo for tracking gaps in Translator data and finding ways to fill them.
7 stars 0 forks source link

In CI UI, the Improve Agent Support Graphs don't seem to display EPC properly #674

Closed sstemann closed 8 months ago

sstemann commented 10 months ago

UI CI - what drugs may treat Hemolytic Anemia > results from Improve like 1-imidazol-1-yl-3-(4-octylphenoxy)propan-2-one

https://ui.ci.transltr.io/main/results?l=Hemolytic%20Anemia&i=MONDO:0003664&t=0&r=66e4b9c5&q=ee706588-2c77-41fa-8bb0-cdf332880fb8

In the ARAX GUI it looks like the support graph displayed the Associated With edge with primary KS spoke

Result Graph image

Support Graph image

The UI displays Associated With edge without any EPC image

I don't know if this is a UI issue or an Improve issue. the infores looks OK

image

dnsmith124 commented 10 months ago

@gprice1129 after looking at what's returned from the BE in the link above the provenance property of that edge is empty. Could you investigate and see if the issue lies with the BE?

gprice1129 commented 10 months ago

@sstemann @dnsmith124 @sierra-moxon the SPOKE source is not showing up because it is missing an xref (link to source) in the catalog.

sierra-moxon commented 10 months ago

The master/main branch of Biolink Model now contains the SPOKE URL in the infores catalog.

dnsmith124 commented 10 months ago

@gprice1129 will this fix show up in the UI automatically or will we need to update the infores catalog in the UI specifically?

gprice1129 commented 10 months ago

@dnsmith124 we will have to update the catalog. That means our biolink-model version and infores-catalog will be from different versions of the biolink-model repo, but I do not think that will matter.

sierra-moxon commented 10 months ago

@gprice1129 - is this on the docket for release this cycle?

sierra-moxon commented 10 months ago

@suihuang-ISB - will you point me to the wiki page you want here? :)

brettasmi commented 10 months ago

@sierra-moxon , we don't have a wiki page for SPOKE KP itself, only the improving agent: https://github.com/NCATSTranslator/Translator-All/wiki/imProving-Agent, which has some details for SPOKE

An external page for the whole SPOKE project is located here: https://spoke.ucsf.edu/

If we need a dedicated page for SPOKE KP, then I can work on that next week.

suihuang-ISB commented 10 months ago

@sierra-moxon , we don't have a wiki page for SPOKE KP itself, only the improving agent: https://github.com/NCATSTranslator/Translator-All/wiki/imProving-Agent, which has some details for SPOKE

Thanks, Brett. I did not realize that this was about a SPOKE specific reference and not the imPROVING Wiki which has the detailed description of evidence by pointing to both SPOKE and the PSEV algorithm, incl. link to the SPOKE home page. SO we do not need two distinct Wikipages but we should be able to use the existing one - https://github.com/NCATSTranslator/Translator-All/wiki/imProving-Agent#propagated-spoke-entry-vectors-psevs

Why it is not there in t his specific example - I don't know - I cannot replicate the 1-imidazole answer... (not returned anymore)

dnsmith124 commented 9 months ago

@gprice1129 can you confirm if this will be in our next release?

gprice1129 commented 9 months ago

We are currently looking at how we should display missing URLs

sstemann commented 9 months ago

hoping this gets resolved for lobster 1? seems like there has been some change, now it looks like this: image

https://ui.ci.transltr.io/main/results?l=Hemolytic%20Anemia&i=MONDO:0003664&t=0&r=0&q=376297df-7f59-417c-8d07-dda01eba74f5

dnsmith124 commented 9 months ago

@sstemann we are planning on resolving this for lobster 1

dnsmith124 commented 9 months ago

This issue is resolved on CI. Whenever a knowledge source is returned without a url to link to, "Link Unavailable" is displayed instead.

dnsmith124 commented 8 months ago

Issue has been resolved, closing.