search

NCATSTranslator / Feedback

A repo for tracking gaps in Translator data and finding ways to fill them.
7 stars 0 forks source link

Unexpected Application Error #708

Closed sstemann closed 9 months ago

sstemann commented 9 months ago

Steps to reproduce:

  1. Click https://ui.test.transltr.io/main/results?l=Aicardi%20Syndrome&i=MONDO:0010568&t=0&r=0&q=d30239ed-f1ac-42dd-af25-4768997d8b79 - which should be results for MVP1 > Aicardi Syndrome
  2. In the filters select Reasoning Agent > ARAGORN - really any ARA image
  3. I also can't page the results
dnsmith124 commented 9 months ago

Looking into this now

dnsmith124 commented 9 months ago

It looks like the error was caused by an orphaned path assigned to a result, but no path actually existing in the data. When building out the graphs for each result, the data for each path is retrieved from a master list, but since that master list didn't have the path in question, it caused the above error.

I've added in a check to make sure that each path exists before trying to access its data, otherwise the orphaned pathID will be logged to the browser console in order to help with future debugging.

Will update once this has been deployed to CI.

dnsmith124 commented 9 months ago

Confirmed resolved in CI, should go out in a TEST deployment later today as well.

It looks like the orphaned paths are coming from Aragorn. Here are the links from my retest of the issue in CI. https://ui.ci.transltr.io/main/results?l=Aicardi%20Syndrome&i=MONDO:0010568&t=0&r=0&q=fbf8ea0a-ba31-4a33-be78-4387a8931c40 https://arax.ci.transltr.io/?r=f2c2b103-cfd2-4bb1-a163-f1dee10f35d0 Sodium is one of the results that demonstrates the issue.

@MarkDWilliams I'm assuming there's something wrong with these paths that's causing them to be removed during merging?

gprice1129 commented 9 months ago

@dnsmith124 this is almost certainly my fault as the ARS has no notion of a path.

gprice1129 commented 9 months ago

I also pushed a fix and tested that it fixed the root cause. I'm going to close this ticket.