NCATSTranslator / Feedback

A repo for tracking gaps in Translator data and finding ways to fill them.
7 stars 0 forks source link

Evidence Model - I wish it indicated Lookup vs Inferred #713

Open sstemann opened 8 months ago

sstemann commented 8 months ago

image

I realize its a one-hop so I should infer this is lookup evidence, but I lose track and it would be helpful if this modal also indicated path type.

dnsmith124 commented 8 months ago

@sstemann the arrow icon behind the edge is intended to communicate this, just confirming that this indication is too subtle in your opinion?

gglusman commented 8 months ago

It's clear when seeing both types of arrows (dashed vs. continuous) at the same time, but the distinction gets lost when expanding details.

sstemann commented 2 months ago

@dnsmith124 i dont think there is any change here. while i can't replicate the request in MVP2 if you look at MVP1 which has one-hop support paths I think you could see where this request originated from

https://ui.test.transltr.io/main/results?l=Attention%20Deficit%20Hyperactivity%20Disorder,%20Inattentive%20Type&i=MONDO:0005302&t=0&r=0&q=3ca59f4c-2539-49a3-ad67-4bd19a855026

image

this is the EPC of the Lookup path image

this is the EPC of the one-hop inferred path image

another example where the predicate changes slightly image

this is the EPC of the lookup path image

this is the EPC of the one-hop inferred path image

but as a user - when i'm looking at one-hop EPC, i dont know if its part of a support or not.

sstemann commented 1 month ago

i'm still wishing for more distinction. After thinking about it further - if the modal said Evidence for Inferred Edge and then Evidence for Supporting Paths

Here is an inferred edge: image

Here is one of it's supporting path edges: image

If the title had more info, I think it might help

dnsmith124 commented 1 month ago

@sstemann this is actually a feature of the facelift that I ran out of time to implement in the previous sprint, I plan to implement it during the current sprint. Here's a screenshot of the design to show what it'll look like: Screenshot 2024-08-30 at 10 03 33 AM