NCATSTranslator / Feedback

A repo for tracking gaps in Translator data and finding ways to fill them.
7 stars 0 forks source link

inferred edge "affected_by" while all predicates in reasoning are "has_increased activity or abundance" #758

Closed TranslatorIssueCreator closed 1 week ago

TranslatorIssueCreator commented 7 months ago

Type: Bug Report

URL: https://ui.test.transltr.io/main/results?l=Potassium%20Ion&i=PUBCHEM.COMPOUND:813&t=3&r=0&q=66f83ee1-3054-4d7a-8e7b-35def1c1a267

ARS PK: 27730ac2-b19e-4edd-b146-7a79551965b0

Steps to reproduce:

What genes are upregulated by potassium ion?

Screenshots:

sandrine-muller commented 7 months ago

image

Why is the inferred predicate not has increased activity of abundance? Result is from unsecret, on ARAX UI you can look at the qualified statement for the result graph that is Acetylcholine biolink:causes increased activity_or_abundance of Choline O-Acetyltransferase which does not seem to translate properly in the UI? image

Same for a lot of results (here is another example) image

gprice1129 commented 7 months ago

@sandrine-muller could you explain more about why you think this is a UI issue? For the first and third screenshot the underlying data for inferred edge shows that the predicate is "affected by", so that seems correct.

For the second screenshot I'm quite mystified about what it is you're looking at. On the top left I see the result is VPS51 but in the graph I don't see a reference to that node anywhere. Can you provide exact instructions on how you arrived at that result in the ARAX UI and also provide a screenshot on what it looks like in the Translator UI?

sandrine-muller commented 7 months ago

@gprice1129 Perhaps that is due to my misunterstanding of how qualified statements are shown in the UI (note that I have not triaged as a UI issue per se) This issue to me comes from the fact that, in the UI, when I see all the evidence under 1 statement (e.g. VPS51 affected by ...) that has the qualifiers "has increased activity or abundance" only, it looks to me as there is a "mismatch" in inferrence: I would expect the whole statement to be VPS51 has increased activity or abundance caused by and not simply affected by This distinction for me is even more interesting to make for a user as it would differentiate cases like this one (although this one is a bad example as the output node normalization is wrong): image where the inferred affected by comes from different predicates (we could potentially get the same output as well if the qualifers are different for the same predicate). For the second screenshot, if you copy paste the pk on ARAX UI, you can have access to the aux graphs, I believe that is what it was? I could not reproduce though, the results are different now.

gprice1129 commented 7 months ago

@sandrine-muller I think for this issue you should tag the underlying ARAs/KPs. The UI team is of the opinion that we should not be altering the predicates we are given to match expectations and instead the reasoning or underlying data should be improved.

sandrine-muller commented 7 months ago

@sierra-moxon Please provide guidance here, thank you so much!

sierra-moxon commented 6 months ago

If I understand the ticket correctly, we are interested in the inferred predicate matching the only existing predicate in the supporting edges instead of being "rolled up" to the affects predicate (maybe this is a default for inferred edges from Unsecret in this use case?)

@kaiwenho - is this something you can help us sort out?

kaiwenho commented 5 months ago

From the Translator Architecture Committee Meeting on May 21 2024:

  1. ARAs should include qualifiers specified in the query graph (the object aspect qualifier and the object direction qualifier for now; like it in the first attached example (Aragorn) below) in the inferred edges.
  2. Should the qualified predicate be included in the query graph and the returned inferred edges? @cbizon would like to dig into this deeper offline.

Attaching two kinds of presentations of the answers for query 'What genes may be upregulated by Potassium Ion' from UI (@Genomewide) From Aragorn - predicate: Affected By; object aspect qualifier: Activity Or Abundance; object direction qualifier: Increased

Screenshot 2024-05-21 at 2 48 30 PM

From BTE - predicate: Affected By

Screenshot 2024-05-21 at 3 06 17 PM

Unsecret Agent will improve the answers by adding object aspect qualifier and object direction qualifier in the inferred edges.

gprice1129 commented 5 months ago

The UI team has updated the MVP2 query to include the qualified predicate biolink:causes in the query graph. This change is live in CI.

gprice1129 commented 5 months ago

@cbizon @kaiwenho we had to roll back the above change in CI for the time being. It seems to be causing some issues for BTE.

kaiwenho commented 4 months ago

This issue has been fixed in Unsecret CI, Test, and Prod.

Screenshot 2024-07-01 at 8 41 23 PM
sstemann commented 1 week ago

looks resolved

image