NCATSTranslator / Feedback

A repo for tracking gaps in Translator data and finding ways to fill them.
7 stars 0 forks source link

Many results are returned more than once for What treats headache #771

Closed khanspers closed 2 months ago

khanspers commented 4 months ago

Query: What drugs may treat headache? Results from https://ui.test.transltr.io/: https://ui.test.transltr.io/main/results?l=Headache&i=HP:0002315&t=0&r=0&q=615645d1-78c0-48fd-b3e8-1c9a4ea47a3a

Many of the results are returned more than once, with different number of paths and scores.

Same story with Sumatriptan, Ergotamine, Almotriptan etc.

Shouldn't the duplicated results be collapsed into one answer?

sierra-moxon commented 4 months ago

@gaurav - I imagine this is a chemical entity id_prefixes issue? (we discussed in DM call today that the revised id_prefixes in Biolink won't be release for another ~ 4 weeks. Should we just slot this in for after that refactor, or is there anything else we can do here?)

gaurav commented 2 months ago

I'm not seeing a lot of duplicates on Test now: https://ui.test.transltr.io/main/results?l=Headache&i=HP:0002315&t=0&r=0&q=6067fe39-a0aa-4118-81fa-d2426be8a61f

I specifically checked the ones in the original ticket, and all the remaining "duplicates" look okay to me:

So it looks like this was a drug-chemical conflation issue that has now been fixed. I'll go ahead and close it, but please reopen or open another ticket (here or on https://github.com/TranslatorSRI/Babel/issues) if any of those terms should be conflated or if we're over-conflating terms.