Closed sstemann closed 3 months ago
Seems like 2 issues:
I also think we should add "Promoter" and "Double Stranded Rna" to the block list (found in MODY results)
I agree with @sstemann that 'Genes' was general and blocked. Messenger RNA -treats-> Maturity-onset Diabetes Of The Young
is the inferred edge generated by Unsecret, with the supporting edges
Messenger RNA -affects-> Genes
Genes -causes-> Maturity-onset Diabetes Of The Young
and both supporting edges are coming from semmeddb. I am assuming these two 'bad' edges were blocked by ARS, since in the ARAX GUI the supporting edges are still there, but they are not in the UI. However, the inferred edge has not been blocked/removed even all (4 in total) supporting edges were gone (/blocked).
@MarkDWilliams if all of the paths are removed, shouldn't the overall result be removed as well?
Also add "Response Elements" which I found in running "treats Marfan Disease"
Also "Elements"
copper atom too?
from the relay: Many of the "rerun results" above should be on the block list. If a result shows as an inferred path but contains a blocked item, then ARS will return the blocked edge; if ARS returns all evidence, then it removes all of it but isn't touching the primary knowledge source edge, which then shows up as a lookup (cause no support graphs)...
todo: just get rid of everything - no bare assertions without support graphs.
I believe I have a fix for this now. Just to make sure we're all on the same page about it, with this fix
All said, just to give an idea of numbers it looks like these are the differences in the number of things removed from Unsecret's merged response pre vs post fix: Nodes: 25 -> 25 Edges: 289 -> 386 Results: 24 -> 105 Aux graphs: 128 -> 128 Analyses: 16->99
I have not yet added all the excellent blocklist additions mentioned in this thread yet (I will do that next), but just as a heads up that the numbers above are likely to get larger
This sounds good to me!
retested on test this morning; seeing copper atom, etc. in the results. For messenger RNA, I still see the one lookup path.
trickle up is working in Test!
https://ui.test.transltr.io/main/results?l=Maturity-onset%20Diabetes%20Of%20The%20Young&i=MONDO:0018911&t=0&r=0&q=f8de3997-f479-49c7-b9ed-b15dc9db9ae4
the messenger RNA answer, via the UI, only has evidence "Unsecret Agent"
in the ARAX GUI the Support Graph says Genes are part of the inference, maybe Genes was general and blocked but the "lookup path" remains? In general though, isnt this just too generic?