NCATSTranslator / Feedback

A repo for tracking gaps in Translator data and finding ways to fill them.
7 stars 0 forks source link

TRAPI Validation Error - ARAGORN - Seems to prevent the UI from displaying Support Paths #853

Open sstemann opened 2 months ago

sstemann commented 2 months ago

Related to #852

https://ui.test.transltr.io/main/results?l=Photosensitivity%20Disease&i=MONDO:0006597&t=0&r=0&q=d649a66d-da78-4ff0-9cd7-621d7949e53b

Symptoms in the UI, this path is interpreted at Lookup: image

The EPC Is limited to ARAGORN: image

Symptoms in ARAX GUI, the ARAGORN and ars-ars-agent Agent results do not load. One hover you see these messages: image

Since I'm not going to the JSON level, it seems like the lack of Support Graphs in the UI from ARAGORN is related to these errors, and should not be ignored unless we can understand how much of an impact this is having across more results.

Here's another example from Test: 95f07fd8-7a5a-4073-b2b8-19341c1cf530

gprice1129 commented 2 months ago

I'm going to take a look at this quickly from the UI side. Will report anything I find.

sierra-moxon commented 1 month ago

From TAQA:

We think Aragorn is already working on this; Aragorn plan a fix for this coming in CI.

sstemann commented 1 month ago

this is still broken in Fugu on Test

https://ui.test.transltr.io/main/results?l=Photosensitivity%20Disease&i=MONDO:0006597&t=0&r=0&q=ace59071-9d2d-4958-850b-11bb95b855a3

It looks fixed on CI but wont be in the Fugu Release unless it gets pushed to Test

https://ui.ci.transltr.io/main/results?l=Photosensitivity%20Disease&i=MONDO:0006597&t=0&r=0&q=4f2d22b3-6f4a-4b25-89ce-12b3209c0d79

sstemann commented 1 month ago

@cbizon it looks like in Test, ARAGORN no longer returns results for Photosensitivity Disease - not sure if that's the fix?

https://ui.test.transltr.io/main/results?l=Photosensitivity%20Disease&i=MONDO:0006597&t=0&r=0&q=881db744-ceee-4b2f-a30d-bb1ddaa23895

https://arax.ci.transltr.io/?r=881db744-ceee-4b2f-a30d-bb1ddaa23895

image

cbizon commented 1 month ago

It's not the fix - there was a bugfix that would allow the support paths to be shown. However, there was another fix in which we removed certain rules that produced bad results, and that included all of the results for photosensitivity disease. So you can no longer see the problem for this query. I suggest that we close this one.

sstemann commented 2 weeks ago

seems like some support paths are still not making it to the UI. In Prod > MVP1 > Photosensitivity Disease

For Result Chloroquine - in the ARAX GUI I see a path that goes through Polymorphic Light Eruption:

image

This path isnt in the UI UI https://ui.transltr.io/results?l=Photosensitivity%20Disease&i=MONDO:0006597&t=0&r=0&q=2f8d4386-b7c7-41bb-9504-dac40b0ba4ef

image

There also seems to be some edge support graphs that aren't displayed in either GUI. I'm not diving into the JSON but here it looks like this edge is expecting 6 support graphs

image

And when I click through them in the ARAX GUI, 1-5 are "blank" and the sixth one is the one above.

image

I dont know how wide ranging this issue is.