NCATSTranslator / Feedback

A repo for tracking gaps in Translator data and finding ways to fill them.
7 stars 0 forks source link

Inferred Edge Should Match Fully Qualified Query Graph Edge - MVP2 #855

Closed sstemann closed 3 months ago

sstemann commented 4 months ago

I dont fully understand why the predicates differ so frequently, when I read them in the UI, I'm not sure I understand how substantially different to the reasoned answer

"Tamoxifen Causes Decreased Activity Or Abundance Of Arid1a" vs "Tamoxifen Affects Decreased Activity Or Abundance Of Arid1a"

then the more general "Tamoxifen Affects Arid1a"

image

https://ui.test.transltr.io/main/results?l=ARID1A%20(Human)&i=NCBIGene:8289&t=2&r=0&q=1d650508-5292-4faf-a52c-21954c89fb36

When I look at it in the ARAX GUI ARAGORN

The support graph of the prediction - looks to be a TMKP lookup

image

ARAX

BTE

all but one of these SG edges are TMKP

image

Unsecret

sstemann commented 4 months ago

@sierra-moxon i'm not sure if any one thing is actually wrong here, but do you have guidance?

sierra-moxon commented 4 months ago

I believe these are all the same result and need to be merged.

How do we get to a merge?

In the back of my mind, it seems a little odd that we have inferred edges that seem to be just reiterating the lookup edges. Am I misunderstanding these results?

sstemann commented 4 months ago

i believe ARS treats these edges as unique and doesnt merge them but defer to @MarkDWilliams @gprice1129

gprice1129 commented 4 months ago

The predicate variation (especially Affects Decreased Activity Or Abundance Of) seems to be a mistake from the ARA/KP. We will look into why the edges in the first screenshot are not being compressed.

dnsmith124 commented 4 months ago

After reviewing the pk again in the UI the edges in the first screenshot are now being properly compressed

sstemann commented 4 months ago

i see some compression but i dont particularly understand how these are substantially different that they need to be displayed this way (my question my really be - do the ARAs really have different intentions here or are they just non-standardized for some other reason)?

image

sierra-moxon commented 4 months ago

from TAQA: lets try this in CI and see if it works - we think BTE was fixed to use the qualified_predicate in the query. e.g. we think BTE, Aragorn will respond to a query with qualified_predicate (but we need to test via ARAX and make sure no ARAs are always left out).

then we need the UI to pass the qualified_predicate to the ARs.

Sui: too many predicates saying the same thing, eg "chemical affects expression of x" - gets mapped differently in the UI? In two-hop answers, we have down and up-regulated (can mean expression, activity, etc), a-upregulates-b- upregulates-c)

colleenXu commented 3 months ago

For BTE:

sierra-moxon commented 3 months ago

retested on CI today, far fewer predicates, more merging. did not spend too long evaluating results but the original issue to me, is fixed.

sstemann commented 3 months ago

this is in prod