Inferred Edge Should Match Query Graph Edge - MVP1

NCATSTranslator / Feedback

A repo for tracking gaps in Translator data and finding ways to fill them.

7 stars 0 forks source link

Inferred Edge Should Match Query Graph Edge - MVP1 #872

Closed sstemann closed 1 week ago

sstemann commented 1 month ago

UI Test > MVP1 > Cystic Fibrosis https://ui.test.transltr.io/main/results?l=Cystic%20Fibrosis&i=MONDO:0009061&t=0&r=0&q=01f390c0-0d65-4dcc-a6ea-4b1749ec10b2

Look for Result Ritonavir

ARAX - Treats Or Applied Or Studied To Treat - Support Graph

BTE - Treats Or Applied Or Studied To Treat - DIrect

ARAGORN responded with 0 results, Ritonavir was not in the results from Improve or Unsecret.

sstemann commented 1 month ago

related to #871 and #870

cbizon commented 1 month ago

I split out out the ARAGORN issue (0 results) from this one, and removed aragorn people.

cbizon commented 1 month ago

It looks to me from the ARAX interface that both ARAX and BTE are returning an edge with a "treats or applied or ..." rather than the requested "treats" edge. I think that if these don't match then there's an inference and this should be shown as a support graph rather than the top level result.

sstemann commented 1 month ago

@cbizon i included you as architecture because I wasn't sure where this decision about treats/inferred lives.

cbizon commented 1 month ago

Oh, gotcha, thanks

colleenXu commented 3 weeks ago

There is now a fix deployed to BTE CI. BTE should now return "an inferred treats edge with the tmkp edge in a support graph" - which is what Chris Bizon recommended.

sierra-moxon commented 1 week ago

closing as complete with Colleen's comment and Chris's comment about splitting the other work into a different ticket. also retested on CI b/c I wasn't sure if TEST was ready for testing yet, and CI is no longer showing the longer predicate in the inferred area, just the support path area.

sstemann commented 2 days ago

this is resolved in Prod, Fugu