search

NCATSTranslator / Knowledge_Graph_Exchange_Registry

The Biomedical Data Translator Consortium site for development of Knowledge Graph Exchange Standards and Registry
MIT License
6 stars 3 forks source link

Can upload incorrect file to the wrong content type but can't delete #42

Open jeffhhk opened 3 years ago

jeffhhk commented 3 years ago

Here I was confused about the order of operations and made a mistake:

image

I have files named both notes.tsv and edges.tsv uploaded to the KGX Content Type=edges field. Now I can't delete.

Here is what I did: 1) Select KGX Content Type=nodes 2) Browse to file and select nodes.tsv 3) Click upload and wait 4) When the upload was finished, nodes.tsv was still selected under "Browse..." but I was so surprised by this that I didn't notice at first 5) Select on KGX Content Type=edges 6) Thinking I was going to select a file, clicked on "Upload". What actually happened was that nodes.tsv was uploaded for a second time into the KGX Content Type=edges field. . . .

Possible solutions include:

RichardBruskiewich commented 3 years ago

Thanks @jeffhhk, we have in mind to implement issue https://github.com/NCATSTranslator/Knowledge_Graph_Exchange_Registry/issues/36 which should provide a means of repairing incorrectly tagged uploaded files.

That said, we'll review the UI and upload code to see if the file type shouldn't just be inferred from the file name, since other software (e.g. KGX) constrains file content in that fashion (@kbruskiewicz we should take note of this)

RichardBruskiewich commented 3 years ago

Related to https://github.com/NCATSTranslator/Knowledge_Graph_Exchange_Registry/issues/22

It may be helpful for us to immediately enhance the upload form to all for repair of a file set in progress, or to redesign the form to make it more fool proof from end user faux pas.

jeffhhk commented 3 years ago

As a point of clarification, I would not expect the ability to delete after "Done Uploading" operation has taken place.