search

NCATSTranslator / Knowledge_Graph_Exchange_Registry

The Biomedical Data Translator Consortium site for development of Knowledge Graph Exchange Standards and Registry
MIT License
6 stars 3 forks source link

Accidentally registered a new Knowledge Graph #44

Open jeffhhk opened 3 years ago

jeffhhk commented 3 years ago

I accidentally registered a second Knowledge Graph:

image

It appeared to me that since my previous upload had crashed, that the KG registration had been deleted due to being empty or something.

It seems like displaying the list of KGs as a list of hyperlinks, (so long as that list of KGs is how long I think it is supposed to be for translator, we have roughly a dozen unique KGs) instead of as a dropdown box would do a better job of discouraging accidental KG registration.

RichardBruskiewich commented 3 years ago

Hi @jeffhhk, your first upload did end up in a somewhat strange state in the archive for a variety of reasons. I patched some of the aberrant content The data files seem to be there, but we'd need to confirm that the data is intact (maybe we can computer sha1 or equivalent hashes on both sides, to confirm content identity).

Also, as I think I mentioned on Slack, the file set lacks a content metadata json (as generated by KGX). In the future, we may have a facility for generating that file on the server side, but not at the moment, hence the metadata upload option.

I suppose a scrollable window of clickable links might be less prone to the duplication issue you mentioned. We will take this idea to heart.

RichardBruskiewich commented 3 years ago

It seems like displaying the list of KGs as a list of hyperlinks, (so long as that list of KGs is how long I think it is supposed to be for translator, we have roughly a dozen unique KGs) instead of as a dropdown box would do a better job of discouraging accidental KG registration.

Hi @jeffhhk,

Hyperlinks are probably not the correct UI form here since selection of a KG triggers the display of related versions. Hyperlinks generally trigger navigation to a new page. There is also the consideration of somewhat limited web screen real estate.

If you are concerned about KG visibility, we could contemplate changing the drop box to a scrollable list box instead. That would keep the essential nature of the "selection" of a KG, while making the list more obvious.

Coupled with that could be a simple updated view which gives some more basic "provider" information for the KG (as subset of the information visible at the end of the View Metadata). Or perhaps, if feasible, the main page and metadata view could be merged(?) although I'd have to ponder what the (performance) impact of that would be.

On the issue of number of KGs, hard to say: I suspect that there may be more than just a dozen data sets over time.