search

NCATSTranslator / OperationsAndWorkflows

A repo for the nascent "operations and workflow" language
0 stars 5 forks source link

Create lookup+score #53

Closed cbizon closed 3 years ago

cbizon commented 3 years ago

We've asked people to implement and expose "lookup". But it was pointed out on the standup call last Friday that while "lookup" is a good default op for KPs, we usually ask ARAs for [lookup + score] combination. Some ARAs are able to pull these apart, but others are not (e.g. Explanatory Agent, maybe others?).

So, the proposal is to create a combined lookup+score op.

dkoslicki commented 3 years ago

Mind taking a crack at this @finnagin since you have quite a bit of experience with implementing new operations?

finnagin commented 3 years ago

Sure!

@dkoslicki @cbizon what should we call this operation? Just "lookup_score" or something else?

Also, should it be a sub-operation of lookup or it's own thing?

dkoslicki commented 3 years ago

I think lookup_and_score is nice and explicit. I think it may need to be its own thing (since it's not clear to me why it would be a subclass of lookup and not a subclass of score too).

finnagin commented 3 years ago

I like lookup_and_score. I'll do that then.

Yeah, that makes sense. Thanks!

finnagin commented 3 years ago

Linking the pull request here: #54

Feel free to look at it when you get a chance.

finnagin commented 3 years ago

Closing this since it has been merged