NCATSTranslator / ReasonerAPI

NCATS Biomedical Translator Reasoners Standard API
36 stars 28 forks source link

invalid examples for attribute_type_id #290

Closed andrewsu closed 2 years ago

andrewsu commented 3 years ago

Biolink:has_p-value_evidence and Biolink:has_original_source are given as examples values for attribute_type_id, but neither appear in https://github.com/biolink/biolink-model/blob/master/biolink-model.yaml. If I'm understanding everything correctly, I suggest that biolink:xref and biolink:synonym would be updated and commonly-used attribute_type_ids.

https://github.com/NCATSTranslator/ReasonerAPI/blob/42a9d073a92d7aaba0ddf080e461d2da088003fc/TranslatorReasonerAPI.yaml#L559

edeutsch commented 2 years ago

addressed in PR #302