NCATSTranslator / ReasonerAPI

NCATS Biomedical Translator Reasoners Standard API
36 stars 28 forks source link

Update retrieval_provenance_specification.md #449

Closed mbrush closed 1 year ago

mbrush commented 1 year ago

Minor but helpful clarifications to the spec.

mbrush commented 1 year ago

Yes, thanks Eric. Just fixed all these!

On Thu, Aug 10, 2023 at 1:28 PM Eric Deutsch @.***> wrote:

@.**** commented on this pull request.

Seems pretty good. Could be a little tidier. How about:

  • fix spelling of Retreival
  • Fix "Information Resource" to "InformationResource" to me consistent
  • Remove double space in "in the Edge"
  • Maybe Edge.source property "contains" rather than "points to"?
  • superfluous comma in source_record_urls?

Aside from these trivial things, it all seems good to me

— Reply to this email directly, view it on GitHub https://github.com/NCATSTranslator/ReasonerAPI/pull/449#pullrequestreview-1572678708, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABHRVVCCCLBEUKZJTYWYP7TXUVAABANCNFSM6AAAAAA3L6D3SY . You are receiving this because you authored the thread.Message ID: @.***>

edeutsch commented 1 year ago

Since there is nothing really new here, just improving the documentation, I'm just going to go ahead and merge.