search

NCATSTranslator / Tests

MIT License
3 stars 2 forks source link

wrong ID for MYC (gene) test #39

Closed colleenXu closed 6 months ago

colleenXu commented 6 months ago

The "NeverShow: cancer decreases activity or abundance of MYC proto-oncogene, bHLH transcription factor" test (Test case 24, asset 312) is using the gene ID NCBIGene:7553. I can see this in the test log https://informationradiator.renci.org/test-runs/53/tests/9184

However, this ID is actually for ZNF7. Instead, I think NCBIGene:4609 is the ID for "MYC proto-oncogene, bHLH transcription factor".

maximusunc commented 6 months ago

I definitely agree that the curie does not match the name. @sandrine-m do you think you could look into this and potentially use NCBIGene:4609 for this asset? I ran it through node norm and it just said MYC, so not sure if that's close enough.

sandrine-muller-research commented 6 months ago

Thanks @colleenXu for reporting this asset. @maximusunc I have not submitted this particular test asset but I can try to have a look at it to try to understand what the user meant (MYC or something else?)

sandrine-muller-research commented 6 months ago

corrected with the proposed NCBIGene:1636 ID in the test asset sheet. Please close if the error does not happen anymore. Thanks

colleenXu commented 6 months ago

NCBIGene:1636 is ACE. So is this meant to be one of the ACE tests (Test case 23 in the sheet)?

sandrine-muller-research commented 6 months ago

Thank you @colleenXu for correcting me. I do not know what are ACE tests. I made a mistake when I responded to you earlier and did not copy paste the good ID in my answer on GitHub. I verified today that the correction I made earlier is the correct ID : NCBIGene:4609 for MYC. I corrected in the Testing QA Pairs from which the test cases are built. I did not edit another sheet. I am not sure if I answered your question?

maximusunc commented 6 months ago

Sounds like this is taken care of.