Answer id normalization

NCATSTranslator / TranslatorArchitecture

MIT License

9 stars 11 forks source link

Closed cbizon closed 1 year ago

cbizon commented 1 year ago

This PR asserts that it is the ARS responsibility to normalize identifiers from ARAs

andrewsu commented 1 year ago

I approve this PR, but add that these two discussion points could also be addressed:

BTE current returns biolink:xrefs and biolink:synonyms for each node. Should the ARS overwrite ARA-provided info, or add to it? Should the ARAs return xrefs and synonyms at all?
Should the ARS also systematically perform name resolution as well? Perhaps the ARS should call the Name Resolution service, and fall back to the ARA-provided name only if that service does not return anything.

MarkDWilliams commented 1 year ago

To summarize our thoughts from the 01/24 Architecture Call,

The ARS will handle this functionality
It will be applied automatically upon receipt of results by the ARS
In the event that an ID is changed, the original one will be retained in a new field on the Message for breadcrumb purposes. https://github.com/NCATSTranslator/Relay/issues/339 @cbizon Could you add the relevant details for Conflation?