NCATSTranslator / minihackathons

MIT License
5 stars 5 forks source link

Aragorn EdgeBinding issue and semantic validation #176

Closed edeutsch closed 3 years ago

edeutsch commented 3 years ago

Someone pointed out to me an issue here: https://arax.ncats.io/?source=ARS&id=548a3208-5335-4aca-9948-128f8b1d1564

where the Aragorn response doesn't render properly in the viewer and the issue seems to be that there are edges and edge bindings to a node that does not exist in the KG (which causes the viewer to not work properly)

        "node_bindings": {
          "n00": [
            {
              "id": "PUBCHEM.COMPOUND:4497"  <-- this one
            },
            {
              "id": "PUBCHEM.COMPOUND:5743"
            }
          ],

First, presumably an issue to fix.

but also reminds me that we ought to do some more semantic validation on the TRAPI messages. This one is valid according to the schema, but not semantically valid (unless I am misinterpreting?)

cbizon commented 3 years ago

Being tracked here: https://github.com/ranking-agent/strider/issues/239

tursynay commented 3 years ago

@patrickkwang and @cbizon, following up for an update, please on this issue

vgardner-renci commented 3 years ago

@cbizon since the dependent strider issue is closed, is this issue resolved?

cbizon commented 3 years ago

Yes