NCATSTranslator / minihackathons

MIT License
5 stars 5 forks source link

improving agent inverting direction? #41

Open cbizon opened 3 years ago

cbizon commented 3 years ago

Sending this query to the ARS:

"message": {
        "query_graph": {
            "edges": {
                "e01": {
                    "object": "n0",
                    "subject": "n1",
                    "predicates": [
                        "biolink:entity_positively_regulates_entity"
                    ]
                }
            },
            "nodes": {
                "n0": {
                    "ids": [
                        "NCBIGene:23221"
                    ],
                    "categories": [
                        "biolink:Gene"
                    ]
                },
                "n1": {
                    "categories": [
                        "biolink:Gene"
                    ]
                }
            }
        }
    }

Results on the arax UI: https://arax.ncats.io/?source=ARS&id=4f29cf84-53af-4099-b4fa-22e9b678eb90

The query is asking (?gene)-[entity_positively_regulates_entity]->(RHOBTB2)

But Improving Agent is returning inverted results, i.e. (RHOBTB2)-[entity_positively_regulates_entity]->(?gene)

image

vgardner-renci commented 3 years ago

@brettasmi & @suihuang-ISB request for update

vgardner-renci commented 3 years ago

@brettasmi & @suihuang-ISB request for update

brettasmi commented 3 years ago

This is an artifact of older code to allow more answers to come back when things were less standardized, i.e. all our searches use undirected edges. This is usually not an issue given two different node types, but you've surfaced a case where a directed edge matters between two of the same node type.

I've created an issue to address this.

tursynay commented 3 years ago

@brettasmi Asking for completion date, please update

jenndoug commented 3 years ago

Mid to late September

jh111 commented 2 years ago

@brettasmi This is not blocking the demo, so I'm removing the demoscript tag. I'm leaving it open as you may want to address it in the future.