search

NCATSTranslator / reasoner-validator

Validation of Translator OpenAPI (TRAPI) messages both to TRAPI and Biolink Model standards. See https://ncatstranslator.github.io/reasoner-validator/
Other
2 stars 4 forks source link

Validation of edge qualifier values is incomplete #91

Closed RichardBruskiewich closed 1 year ago

RichardBruskiewich commented 1 year ago

Edge qualifiers have defined qualifier_type_id terms which map onto value ranges.

Qualifier values not resolved to their qualifier types will trigger a Knowledge Graph Edge Qualifiers Qualifier Value error.

The tricky part of the resolution of such qualifier values is not always directly defined by the qualifier definition itself, but rather, is context sensitive to the particular biolink:Association subclass that is applicable to the given edge. Hence, before validating qualifier values, one generally needs to know the particular biolink:Association child class in question.

At the moment, the applicable biolink:Association subclasses are published in the /meta_knowledge_graph TRAPI endpoint, and needs to be dynamically mapped to a given edge (by subject/object category and perhaps, predicate, matching?) during validation.

We wish to avoid qualifier value errors if, in fact, the Biolink Model range as defined above, is available.

RichardBruskiewich commented 1 year ago

Resolved in https://github.com/NCATSTranslator/reasoner-validator/tree/issue-91-enhance-validation-of-edge-qualifiers, to be released soon once Biolink Model Toolkit 1.1.1 is released, and local poetry dependencies are updated.

KevinBretonnelCohen commented 1 year ago

Hello! Is it possible to remove me from this list, please?

On Thu, Jul 27, 2023, 06:46 Richard Bruskiewich @.***> wrote:

Closed #91 https://github.com/NCATSTranslator/reasoner-validator/issues/91 as completed.

— Reply to this email directly, view it on GitHub https://github.com/NCATSTranslator/reasoner-validator/issues/91#event-9930971867, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARLWGZRJ5BX2DW3LA2AWHDXSHP7ZANCNFSM6AAAAAA2R2HFWE . You are receiving this because you are subscribed to this thread.Message ID: <NCATSTranslator/reasoner-validator/issue/91/issue_event/9930971867@ github.com>

edeutsch commented 1 year ago

Hello! Is it possible to remove me from this list, please?

You can remove yourself by going to the repo top page here: https://github.com/NCATSTranslator/reasoner-validator

and using the Unwatch control to stop getting these emails. Set it to [Ignore] image