NCATSTranslator / reasoner-validator

Validation of Translator OpenAPI (TRAPI) messages both to TRAPI and Biolink Model standards. See https://ncatstranslator.github.io/reasoner-validator/
Other
2 stars 4 forks source link

Fix Qualifier value validation (driven by specific use case) #93

Closed RichardBruskiewich closed 1 year ago

RichardBruskiewich commented 1 year ago

This issue is triggered by the anecdotal observation of the following Aragorn validation error. JSON Response.Message.KnowledgeGraph edges with node category and predicate values as follows

biolink:Gene -- biolink:affects -> biolink:ChemicalEntity

and qualifier annotation

"qualifiers": [
    {
        "qualifier_value": "synthesis",
        "qualifier_type_id": "biolink:object_aspect_qualifier"
    },
...]

trigger a Knowledge Graph Edge Qualifiers Qualifier Value validation error for the above qualifier.

Although the Reasoner Validator appears to be doing its job, it is likely that the Biolink Model (and possibly, the Biolink Model Toolkit) may require some revision. This issue documents the observed reasoner-validator use case, but refer to an associated Biolink Model revision issue and Biolink Model Toolkit revision issue for more details and related activities.

RichardBruskiewich commented 1 year ago

Implemented by release v3.7.6