NCATSTranslator / testing

Materials and tools for testing Translator components
1 stars 9 forks source link

Named Thing associated with Acrocynaosis - Some ARS Agents return 0 Results #12

Open sstemann opened 3 years ago

sstemann commented 3 years ago

Query: https://github.com/NCATSTranslator/testing/blob/main/ars-requests/not-none/acrocyanosis.json PK: 04572ad3-cb85-498c-9b62-4d3eaa8e06d8 From 3/18: a7eb6765-fcf9-45d3-ad38-0fb74388a511 image Results not being returned from: xARA (Explanatory Agent), BTE (Exploring Agent), imProving Agent, Unsecret Agent

Results are being returned from: ARAGORN (Ranking Agent), ARAX (Expander Agent)

What KPs could be used to answer this?

sstemann commented 3 years ago

@andrewsu can you please link your BTE issue to this ticket? @pg427 please let us know the results of your team's discussion to implement namedthing @webyrd please let us know an update for Friday if you get a chance @MarkDWilliams to run another example for imProving Agent @brettasmi

sstemann commented 3 years ago

@brettasmi Mark ran today's query with Gene:EGFR and received this error when sent to Improve directly:

{ "description": "Something went wrong. If this error is reproducible using the same query configuration, please post an issue in the imProving Agent GitHub page https://github.com/suihuanglab/improving-agent timestamp: 2021-03-16T17:36:14.811631", "message": {}, "status": 500 }

Here's the updated query:
{ "message": { "query_graph": { "nodes": { "n0": { "id": "HGNC:3236", "category":"biolink:Gene" }, "n1": { "category": "biolink:NamedThing" } }, "edges": { "e01": { "subject": "n0", "object": "n1" } } } } }

kevinxin90 commented 3 years ago

@sstemann BTE has fixed the issue. Feel free to try it out.

sstemann commented 3 years ago

@sstemann BTE has fixed the issue. Feel free to try it out.

Thanks @kevinxin90 and @andrewsu looks like its working for the two named thing queries we are using now, appreciate the quick feedback!

sstemann commented 3 years ago

@brettasmi Mark ran today's query with Gene:EGFR and received this error when sent to Improve directly:

{ "description": "Something went wrong. If this error is reproducible using the same query configuration, please post an issue in the imProving Agent GitHub page https://github.com/suihuanglab/improving-agent timestamp: 2021-03-16T17:36:14.811631", "message": {}, "status": 500 }

Here's the updated query: { "message": { "query_graph": { "nodes": { "n0": { "id": "HGNC:3236", "category":"biolink:Gene" }, "n1": { "category": "biolink:NamedThing" } }, "edges": { "e01": { "subject": "n0", "object": "n1" } } } } }

@cbizon we were running this query and noticed ARAGORN seems to error on this version of named thing: https://ars.transltr.io/ars/api/messages/6b53b95b-f37b-4cf2-ba9b-e440a640655d - could you take a look and let us know?

sstemann commented 3 years ago

@brettasmi looks like imProve agent is returning results for named thing with the EGFR criteria this morning - thanks!

sstemann commented 3 years ago

Original n0 : "id": "UMLS:C0221347", "category":"biolink:PhenotypicFeature"

Updated n0: "id": "HGNC:3236", "category":"biolink:Gene"

From: cbizon @.> Sent: Wednesday, March 17, 2021 1:32 PM To: NCATSTranslator/testing @.> Cc: Stemann, Sarah (NIH/NCATS) [C] @.>; Mention @.> Subject: Re: [NCATSTranslator/testing] Some ARS Agents Currently Returning 0 Results for Named Thing associated with Acrocynaosis (#12)

What's the difference between this query and the one that worked in aragorn?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/NCATSTranslator/testing/issues/12#issuecomment-801272099, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AJEL5IXNSHWMJTQ6BRTWRILTEDRPNANCNFSM4ZIU6S2Q.

sstemann commented 3 years ago

update from 4/20/21 PK: a9b45648-d913-4d8f-806d-3bc3f91426b8 image

balhoff commented 3 years ago

CAM-KP doesn't contain any biolink:PhenotypicFeature, so 0 results is expected.

colleenXu commented 3 years ago

I ran the updated query below through the ARS, PK: 598040bf-b933-4def-8885-a59d04175798

Screen Shot 2021-09-21 at 11 32 49 PM

The updated query should be something like this (it's missing the workflow section but the rest is TRAPI v1.2):

{
    "message": {
        "query_graph": {
            "nodes": {
                "n0": {
                    "ids": ["UMLS:C0221347"],
                    "categories":["biolink:PhenotypicFeature"]
                },
                "n1": {
                    "categories": ["biolink:NamedThing"]
                }
            },
            "edges": {
                "e0": {
                    "subject": "n0",
                    "object": "n1"
                }
            }
        }
    }
}