search

NCBI-Hackathons / seqr

Creative Commons Zero v1.0 Universal
12 stars 2 forks source link

Solr Version #17

Open nabihlme opened 8 years ago

nabihlme commented 8 years ago

Note to self: 5e6ab1bbecd816003a0a18578da6c579e14945b6 These lines might belong below the else block: SystemInfoHandler sih = new SystemInfoHandler(container); versionSolr = sih.getVersion();

They might work for both embedded and http solr servers. I'll need to setup a http solr server for testing. I have no idea why there are two constructors, one taking the container and the other doesn't.

http://lucene.apache.org/solr/5_2_1/solr-core/org/apache/solr/handler/admin/SystemInfoHandler.html

(Also, since I might have broken support for http solr servers with that last commit, I need to look into this quickly)

Note to self: Don't accidentally commit a nullpointerexception in the future...

lianyi commented 8 years ago

"need to setup a http solr server for testing"

The aws instance is still working :)

averagehat commented 8 years ago

It would be nice to add a Solr server to Travis whenever that gets up and running

seandavi commented 8 years ago

Check out:

https://github.com/moliware/travis-solr

On Sun, Aug 9, 2015 at 7:13 PM, Mike Panciera notifications@github.com wrote:

It would be nice to add a Solr server to Travis whenever that gets up and running

— Reply to this email directly or view it on GitHub https://github.com/DCGenomics/seqr/issues/17#issuecomment-129259988.

lianyi commented 8 years ago

Thanks Sean for the pointer!