search

NCBI-Hackathons / seqr

Creative Commons Zero v1.0 Universal
12 stars 2 forks source link

Build test #28

Closed averagehat closed 9 years ago

averagehat commented 9 years ago

Closes #24

lianyi commented 9 years ago 
 @Test
+//    public void testArgParse() {
+//        String[] args = {"search",  "testdata/data/test.fasta", "--db", "testdata/solr/"};
+//        Seqr.main(args);
+//
+//        }

Looks this was commented out, Perhaps this test failed on travis?

averagehat commented 9 years ago

@lianyi, The test actually passes, however I removed it because Travis was taking longer than ten minutes to build. Unfortunately that did not work.

Travis runs fine if I do not specify before_script or script or anything like that, but if I do, I get errors like org.apache.solr.common.SolrException: No such core: sequence, like here.

I am not sure what is wrong, but I think there is a difference between what travis does by default and what I am doing, or else maybe travis is trying to run things concurrently when it shouldn't.

lianyi commented 9 years ago

I see, I suspect it's the default heap size for the maven test. Perhaps the heap size can be configured to 1G in travis? Or perhaps just skip this testing unit in travis...

averagehat commented 9 years ago

Yay, finally, I was able to get this working, although I don't quite understand The depth of the problem. Now the robot tests I added (which test the build after the jar is created to avoid problems like #24) are run within the maven test phase, using www.github.com/robotframework/MavenPlugin

So this is ready to merge, you can review if you like, @lianyi, or go ahead and merge.

lianyi commented 9 years ago

I'm working on the merging and it looks great! Good job on getting "robotframework" works!