Index - Githubissues

NCBI-Hackathons / seqr

Creative Commons Zero v1.0 Universal

12 stars 2 forks source link

Index #37

Closed averagehat closed 8 years ago

averagehat commented 8 years ago

Closes #29 This is working on my machine but I will add tests before it's ready for merging

[ ] fix how ID is set
[ ] add tests, inc. with multi-file/entry indexing
[ ] test/fix JSON file loading
[ ] try with big file
[ ] refactor so indexing lives outside of Seqr.handleCommand

lianyi commented 8 years ago

@averagehat Sounds good to you to merge this index branch? Bo is making FASTA indexer and after seeing the diff, It seems best to merge this branch first to avoid minimum code conflict.

averagehat commented 8 years ago

Yes let me see if I can get the build to pass or at least working on my machine. This branch may be a bit outdated from my local code.

Is he creating the fasta indexer as a Solr process/request handler? It would be great if he could make a pull request (or at least issue) even if he is not done, that would help with visibility and not duplicating work.

lianyi commented 8 years ago

@averagehat Gr8! Sounds a good plan!

averagehat commented 8 years ago

You/Bo may want to check out this in the meantime, I think it includes a fasta indexer #44

averagehat commented 8 years ago

The main purpose of this PR was to unify JSON and FASTA indexing. #45 has a different but working approach to that so I am going to close this and open up a new PR