search

NCBI-Hackathons / seqr

Creative Commons Zero v1.0 Universal
12 stars 2 forks source link

schema.xml refers to non-existant class #43

Closed averagehat closed 9 years ago

averagehat commented 9 years ago

see here

lianyi commented 9 years ago

It should be in the jar file. And the implementation should be in the tokenizer branch. However, since we refactor the code to favor the command.line version, where the tokenizer won't fit in the same source code as it has to be a solr plugin, we might want to create another repository to host the tokenizer code. I'll follow up with this, but please reopen the issue this is a blocker to get the seqr.commandline version to work.

averagehat commented 9 years ago

Yes I realized this is what was happening. It's a bit sneaky because the jar file shares a file structure with that project.

Do you think the tokenizer code is a good candidate for BioSolr? I can't quite pin down the scope of that project. If not, we are working on extending solr as well #44 VDBWRAIR/bio_pieces/#62, maybe we I can pull out some stuff that would fit into a cohesive plugin with the tokenizer stuff.

lianyi commented 9 years ago

Right, ideally we should spin off that code as the tokenizer code was loaded by solr, not seqr.cmd directly. I meet with Lewis last week on this topic, and it would be easier and less confusing to create another git repository( will check with Lewis, and Sameer, the lead of BioSolr, if needed).

-lianyi

From: Mike Panciera [mailto:notifications@github.com] Sent: Thursday, September 17, 2015 2:35 PM To: NCBI-Hackathons/seqr seqr@noreply.github.com Cc: Han, Lianyi (NIH/NLM/NCBI) [C] hanl@ncbi.nlm.nih.gov Subject: Re: [seqr] schema.xml refers to non-existant class (#43)

Yes I realized this is what was happening. It's a bit sneaky because the jar file shares a file structure with that project.

Do you think the tokenizer code is a good candidate for BioSolr? I can't quite pin down the scope of that project. If not, we are working on extending solr as well #44https://github.com/NCBI-Hackathons/seqr/issues/44 VDBWRAIR/bio_pieces/#62, maybe we I can pull out some stuff that would fit into a cohesive plugin with the tokenizer stuff.

— Reply to this email directly or view it on GitHubhttps://github.com/NCBI-Hackathons/seqr/issues/43#issuecomment-141180707.