Fix trigger-other-plugins - Githubissues

NCBPFluffyBear / FluffyMachines

A Slimefun4 addon that brings a variety of machines and tools to Slimefun

https://thebusybiscuit.github.io/builds/NCBPFluffyBear/FluffyMachines/master/

GNU General Public License v3.0

23 stars 39 forks source link

Fix trigger-other-plugins #143

Closed TheJohnLong closed 11 months ago

TheJohnLong commented 11 months ago

Short Description

Other plugins could detect air at the block break location, resolve with reorder of calls.

Additions/Changes/Removals

Call AlternateBreakEvent before breakNaturally

Related Issues

Resolves #142

Image Proof

Checklist

[x] I have fully tested the proposed changes and promise that they will not break everything into chaos.
[x] I have tested every variant of every item or config setting that I have added.
[x] I have also tested the proposed changes in combination with base Slimefun and made sure nothing breaks/unexpected happens.
[x] I followed the existing code standards and didn't mess up the formatting.

NCBPFluffyBear commented 11 months ago

This PR has been reverted due to insufficient testing. Received a report that a server is getting StackOverflowErrors. I will look into this later to see if a modification can be applied properly.