search

NCC-CNC / whattodo

Interactive management action prioritization application
https://NCC-CNC.github.io/whattodo
2 stars 2 forks source link

Screenshot icon #37

Open josephrbennett opened 2 years ago

josephrbennett commented 2 years ago

https://www.flaticon.com/free-icons/screenshot

jeffreyhanson commented 2 years ago

Yeah, I agree that the current icon isn't perfect and could potentially cause confusion. I had a look into possible ways to change the icon, and it seems that the R package that provides the screenshot button/functionality doesn't have the functionality to customize the icon for the screenshot button (see here for all the settings we can customize).

So, in order to change the screenshot button icon, we would need to (1) re-implement the function entirely, (2) submit a PR to the package to add in the ability to customize the icon, or (3) fork the R package, tweak it, and then add it as a dependency. Although (3) is simplest option in the short term, this would increase the level of maintenance required for the app a lot (because the same R package also provides a lot of other functionality used by this app, so we would need to make sure any changes in the original version of the package also make it to the fork).

Given all that, I'm not sure if it's worth the hassle for changing the icon? What do you think @josephrbennett?

jeffreyhanson commented 2 years ago

I'll tag this as a sometime issue, but please feel free to update if you think this is important.

jeffreyhanson commented 2 years ago

Woops - sorry, I didn't mean to close the issue.

josephrbennett commented 2 years ago

Sounds fine to me. I didn't realize it'd be such a time-consuming thing. Thanks!