#24 renaming. REFACTOR - Githubissues

NCC-CNC / wtw-data-prep

Scripts to prepare data for Where To Work tool

0 stars 0 forks source link

#24 renaming. REFACTOR #26

Closed DanWismer closed 1 year ago

DanWismer commented 1 year ago

@edwardsmarc, I have completed some major refactoring to our prep scripts. Mainly from the help of wtw-species-prep I was able to generate consolidated metadata spread sheets which reduces the code needed for 04_populate_nat_metadata.R.

The new data can be found on AVD as WTW_NAT_DATA_20230717.zip (once upload is complete)

The idea is once we agree on this PR (and make sure everything still works), I will move on to setting goals in 04_populate_nat_metadata.R as I now have all the pieces.

What do you think?

edwardsmarc commented 1 year ago

This looks good to me @DanWismer. Couple comments:

I pushed a change to deal with ECCC cases where there are only two values but the max is not 100ha. Without this I was getting an error in 05_wtw_formatting.R because the layers did not have values specified.
I noticed 03b_summarize_species.R no longer works because the species table format changed. Not sure if this table is still needed after your changes but though I'd flag it here.

DanWismer commented 1 year ago

Awesome thanks @edwardsmarc, nice catch with the max.

ah yes, I will refactor 03b_summarize_species.R as I can have more meaningful columns using the new metadata.csv files.

Wondering when we should merge this? I still need to get the goals in. It may be nice to do that on a separate branch.

edwardsmarc commented 1 year ago

Awesome thanks @edwardsmarc, nice catch with the max.

ah yes, I will refactor 03b_summarize_species.R as I can have more meaningful columns using the new metadata.csv files.

Wondering when we should merge this? I still need to get the goals in. It may be nice to do that on a separate branch.

I'm happy for you to merge now. I don't have any data-prep coming up. Maybe you can do a v0.9 release before just so we have a copy of the old working scripts in case anything comes up? Then once the refactor is complete we can do release v1.0?

DanWismer commented 1 year ago

Sounds good to me, I will do a release first, then merge. Thanks