search

NCEAS / awards-bot

Award management bot for Arctic Data Center management
6 stars 8 forks source link

Fixes to awards-bot #31

Closed laijasmine closed 3 years ago

laijasmine commented 4 years ago
laijasmine commented 4 years ago

Chris - I think I found the source of the problem that it was reading in the Sys.getenv variables as characters instead of numeric. Made some changes.. hopefully we can test this out some time.

laijasmine commented 4 years ago

@csjx sounds good I'll work through this later today to give more detailed explanations

laijasmine commented 3 years ago

@csjx no rush on this. I finally got back to this and brought back the check_rt_reply function. The difficulty is figuring how to test when it errors. I haven't figured out any good solutions to force RT to throw an error so any ideas on that would be great.

laijasmine commented 3 years ago

@csjx Need to investigate one weird problem I ran into today. Not sure why the test_main function is emailing the PIs when the given example database only has 2 records and should only email me. Not aware that I'm doing anything different from how I have been testing in the past or how it is outlined in the readme. Will see if I can find the cause by just tracing the code.

laijasmine commented 3 years ago

Ok figured it out. Turns out I was accidentally referring to an older awards database from previous testing and was updating the awards database with new awards. I updated the readme file is clear on how to do that from the test_main.R and others in the future shouldn't run into this issue.

I'll merge this file once the checks are complete. @csjx Let me know what the next steps should be.