eml2 refactor - Githubissues

NCEAS / datamgmt

Data management utilities for curating, documenting, and publishing data.

https://nceas.github.io/datamgmt/

Apache License 2.0

15 stars 13 forks source link

eml2 refactor #191

Open dmullen17 opened 5 years ago

dmullen17 commented 5 years ago

[x] add_creator_id
[x] edit_attribute
[x] get_eml_attributes
[x] qa_eml
[x] qa_package
[x] return_eml_units
[x] which_in_eml

jeanetteclark commented 5 years ago

removed which_in_eml as this is in arcticdatautils

jeanetteclark commented 5 years ago

also proposing removal of return_eml_units and create_attributes_table since this functionality is now in EML

jeanetteclark commented 5 years ago

okay, just pushed more commits that amount to a pretty aggressive culling of this package.

I removed: add_creator_id, which_in_eml, return_eml_units, create_attributes_table and qa_eml. The functionality of all of these functions is duplicated elsewhere, with the exception of add_creator_id, but I honestly couldn't see a good use for this function given how easy references are to use in EML 2.0. Definitely going to need feedback on all of this @dmullen17

dmullen17 commented 5 years ago

@jeanetteclark I agree with your reasoning for removing these functions. They're basically highly specific helpers that aren't all that useful or else now duplicated elsewhere.
👍