search

NCEAS / eml

Ecological Metadata Language (EML)
https://eml.ecoinformatics.org/
GNU General Public License v2.0
40 stars 15 forks source link

declarations for units in spatialReference and spatialRaster are inconsistent #217

Open mbjones opened 7 years ago

mbjones commented 7 years ago

Author Name: Margaret O'Brien (Margaret O'Brien) Original Redmine Issue: 3523, https://projects.ecoinformatics.org/ecoinfo/issues/3523 Original Date: 2008-10-09 Original Assignee: Matt Jones

In spatialReference.xsd and spatialRaster.xsd the use of units is inconsistent. eml-spatialReference.xsd defines 2 types which are lists of units, very similar to what is going on in the attribute and coverage schemas (see bug #1019 comment #4).

and each of which is an enumeration that includes a group units which are also in standardUnits, but as implied by the names, their lists are units of type length and angle, respectively. The types are used inconsistently: eml-spatialReference.xsd:2215: eml-spatialReference.xsd:2273: eml-spatialReference.xsd:2386: eml-spatialReference.xsd:2396: eml-spatialReference.xsd:2499: eml-spatialReference.xsd:2508: eml-spatialRaster.xsd 793:
mbjones commented 7 years ago

Original Redmine Comment Author Name: Redmine Admin (Redmine Admin) Original Date: 2013-03-27T21:23:42Z

Original Bugzilla ID was 3523

mobb commented 6 years ago

Clarification: the eml-unitTypeDefinitions.xsd has Types for length and mass units, and the LengthUnitType is used in for altitudeUnits in coverage (MassUnitType is not currently used).

The fix for this bug would be to use that LengthUnitType in spatialReference.xsd and spatialRaster.xsd. And there is even a parallel simpleType for length and angle units in spatialReference.xsd. However, the unit elements (above) are currently typed as strings. So to restrict them now to named Type is a breaking change, so will not happen in 2.2.