NCEAS / eml

Ecological Metadata Language (EML)
https://eml.ecoinformatics.org/
GNU General Public License v2.0
41 stars 15 forks source link

cardinality issue in documentation for children of literatureCited? #376

Closed twhiteaker closed 3 years ago

twhiteaker commented 3 years ago

The schema docs show this:

<literatureCited>
  <citation id="" scope="document" system="">{1,1}</citation>
  <bibtex>{1,1}</bibtex>
</literatureCited>

But the diagram shows one-to-many for children of literatureCited, so should the instance snippet be

<literatureCited>
  <citation id="" scope="document" system="">{1,unbounded}</citation>
  <bibtex>{1,unbounded}</bibtex>
</literatureCited>

Maybe the {1,1} has something to do with this being a xsd:choice?

amoeba commented 3 years ago

Hey @twhiteaker, thanks for the report. I agree it's a bit odd but it looks correct to me.

The cardinality is on the CitationListType and not the elements that make up the type. And the {1,1} cardinality looks like our documentation tool is just being complete since the citation and bibtex elements do have a {1,1} cardinality.

I'd like the examples you posted to look different but I haven't looked into whether or not we can customize the tool enough.

twhiteaker commented 3 years ago

ok thanks!