search

NCEAS / ezid

Implementation of the EZID identifier services in a Java library
Other
4 stars 4 forks source link

make compatibility with the limited DataCite EZID implementation #12

Closed jusana closed 3 years ago

jusana commented 3 years ago

https://support.datacite.org/docs/datacite-ez-api-guide

mbjones commented 3 years ago

Thanks, @jusana Do you know if there is a test DataCite account that I can use to test this code change? If not, I can try to track one down.

jusana commented 3 years ago

Hello @mbjones, well that's a problem i guess. It seems there is no common credentials for a sandbox but dedicated credentials for a personnal env test (as far as i understood) I could give you our credentials for the time of testing ... even though it doesn't seem right i guess @yvanlebras would be ok

Anyways, i also did not write specific tests for the datacite API, so the existing tests (on CDL) would pass but you would need to bypass the 'login' test to pass datacite tests (for instance comment out the .login() step in setup) then hardcode credentials to pass mint or create or delete If needed/required i could write those specific datacite tests, but i also noted that the real life (metacat DOIService.java) does NOT exactly behaves like the tests in the lib

Please don't hesitate to tell me !!

mbjones commented 3 years ago

@jusana I will request a test account from DataCite - they will likely help me out quickly. In the meantime, I do think we want to reconfigure the tests to check against both an EZID and a DataCite test server to ensure that they are both working properly with the changes. I'll wait until I have a DataCite account to start to test this.

yvanlebras commented 3 years ago

Nice Julien! Thank you Matt! If datacite answer is long, feel free Julien to mp our credentials, really nothing sensitive.

mbjones commented 3 years ago

@jusana did you close this PR as a side effect of us renaming master to main? I will reopen it if that is what you wanted. Please let me know.

jusana commented 3 years ago

hi @mbjones , that's it. Actually it seems that the PR was automatically closed when i set "main" as the default branch in the settings. So you can close this one (#12) and keep the #15

mbjones commented 3 years ago

ok, done.