search

NCEAS / metacat

Data repository software that helps researchers preserve, share, and discover data
https://knb.ecoinformatics.org/software/metacat
GNU General Public License v2.0
27 stars 13 forks source link

Temporary files aren't #854

Closed mbjones closed 6 years ago

mbjones commented 6 years ago

Author Name: Brendan Hahn (Brendan Hahn) Original Redmine Issue: 5833, https://projects.ecoinformatics.org/ecoinfo/issues/5833 Original Date: 2013-01-29 Original Assignee: ben leinfelder

Detritus accumulates in the 'temporary' directory. Output files generated by read requests may persist for the lifetime of the application server and will not be cleaned on abnormal termination. Copies of data files are left in the 'uploads' directory.

Temporaries should at least be cleaned on startup/config. Better to remove them immediately after use or schedule a definite deletion Why are these operations staged through temporaries at all? Why does metacat implement its own temporary file management rather than use app-server provided facilities?

mbjones commented 6 years ago

Original Redmine Comment Author Name: Redmine Admin (Redmine Admin) Original Date: 2013-03-27T21:31:49Z

Original Bugzilla ID was 5833

mbjones commented 6 years ago

Original Redmine Comment Author Name: ben leinfelder (ben leinfelder) Original Date: 2013-08-01T21:10:53Z

I changed this to not use those temporary files - either we have it on disk already and can stream fromt there, or we write it to the correct location on disk (from DB) and stream from that file.