search

NCEAS / metacatui-themes

Themes for MetacatUI repositories
1 stars 0 forks source link

Extra margin space at bottom of DRP landing page #5

Closed iannesbitt closed 8 months ago

iannesbitt commented 8 months ago

There is an extra 96-pixel area below the DRP footer that I don't yet understand how to get rid of. Disabling the two settings (below) that define it seem to only put it below the bottom limit of the browser window, so it seems like it's only there in order to push the footer up the page and back into the viewable window at load time. It also doesn't matter how tall the mainContent is, the footer always has 96 px of bottom-margin/padding. 

  margin-bottom: -6rem;
  padding-bottom: 6rem;

image

iannesbitt commented 8 months ago

Found it. The margin property under mainContent { (line 2120 in updated metacatui.css) was missing a character. First position should have been -180 instead of -80:

-    margin: -80px -40px -160px -80px;
+    margin: -180px -40px -160px -80px;
iannesbitt commented 8 months ago

I think this means the mainContent padding-top should be increased in the #2 fix, as this change moves the div container up the page too far:

image

iannesbitt commented 8 months ago

Oops, committed to the wrong branch...cherry-picked changes over to here from #7 then reverted #7's branch back two commits.