Add EML 2.2.0 Support in search catalog and dataset landing pages

NCEAS / metacatui

MetacatUI: A client-side web interface for DataONE data repositories

https://nceas.github.io/metacatui

Apache License 2.0

42 stars 26 forks source link

Add EML 2.2.0 Support in search catalog and dataset landing pages #1055

Closed amoeba closed 5 years ago

amoeba commented 5 years ago

Metacat is getting EML 2.2.0 support (https://github.com/NCEAS/metacat/issues/1239) which affects MetacatUI in the following ways:

[x] We can turn the Annotation filter back on in search so people can search for semantic annotations
[x] We can render Markdown properly on landing pages with the MarkdownView
[x] We need to build an interactive widget on dataset landing pages for Semantic Annotations. See https://github.com/NCEAS/metacatui/issues/943

amoeba commented 5 years ago

PR at https://github.com/NCEAS/metacatui/pull/1034. Demo at neutral-cat.nceas.ucsb.edu.

amoeba commented 5 years ago

Decisions left:

[ ] Which release this is going into? It looks like 2.6 is closed so the earliest this can go in is 2.7.
[x] Which themes do we enable the annotation filter on?

amoeba commented 5 years ago

Re:

Which release this is going into? It looks like 2.6 is closed so the earliest this can go in is 2.7.

@laurenwalker where would this fit in terms of release versions?

Which themes do we enable the annotation filter on?

We decided on this call that we'll keep the annotation filter turned off in version control and enable it on a per-deployment basis.

laurenwalker commented 5 years ago

Hey Bryce, I merged your PR into the dev-2.7 branch for a 2.7.0 release. This will be the only feature in that release, so as soon as EML 2.2.0 is officially released, we can tag 2.7.0.

I tried testing your changes with neutral-cat but was getting server errors

amoeba commented 5 years ago

Thanks! Sorry for the errors, I nuked Metacat on neutral-cat before I left the office last night in order to test something else and didn't bring it back up yet.

amoeba commented 5 years ago

Okay, I set up https://mn-demo-8.test.dataone.org/ as a "stable" place with EML 2.2.0 support for both Metacat and MetacatUI.

laurenwalker commented 5 years ago

I tested these changes and they look really good. I turned the annotation search filter on in the arctic theme.

I made some minor design changes, just to keep the designs of the annotations more consistent with the rest of the app's look. I changed the annotation popover so that it displays on hover, rather than click. I also changed the annotation icon to the check mark inside a "certificate" icon, like we talked about during a couple meetings. That required a change to the eml-attribute.xsl stylesheet in Metacat on dev-2.11.

I updated mn-demo-8 with all those changes so anyone can take a look. Here's also some screenshots:

Before

After

Screen Shot 2019-08-23 at 3 45 45 PM

amoeba commented 5 years ago

Looks way better, thanks @laurenwalker !