NCEAS / metacatui

MetacatUI: A client-side web interface for DataONE data repositories
https://nceas.github.io/metacatui
Apache License 2.0
42 stars 26 forks source link

Update JSON-LD implementation to match Google's new Schema.org guidelines #1074

Closed amoeba closed 4 years ago

amoeba commented 4 years ago

Google's Structured Data Testing Tool now complains about use of:

  1. Error: Untyped creator and publisher properties

    Thing is not a known valid target type for the creator property.

  2. Warning: No license

    The license field is recommended. Please provide a value if available.

(1) can be done right away, (2) isn't yet indexed but I can patch it in later. https://schema.org/license takes either a CreativeWork or a URL so we can use EML 2.2.0's new LicenseType url property once that's in.

amoeba commented 4 years ago

This is done but I'll leave it open for comment until it gets automatically closed when released (merged into master).

laurenwalker commented 4 years ago

So does the license still need to be added to the JSONLD, because we don't index licenses yet?

amoeba commented 4 years ago

Yeah

laurenwalker commented 4 years ago

OK, I added a new issue for the licensing so we don't forget to add it later https://github.com/NCEAS/metacatui/issues/1076